Erado Review

We are sorry to have taken up so much of your time.

Following bug list we fixed.

58. Logo looks blurry on HiDPI displays and mobile: https://envato.d.pr/XS04Ru
Screenshot on Macbook Pro 15 Inc (2880px)
screenshot on  Iphone 7s plus

57. In English 1 is singular, other numbers are plural. https://envato.d.pr/Pknhmz

56. Footer inconsistent widget area width: https://envato.d.pr/2arb7k

fixed: we had fixed that for new installation.

55.

Still: There are a few inconsistent spacing/padding as well as alignment issues throughout the design. I’d like you to go over it with a fine toothed comb and weed out these basic design issues.

Example(s):
– https://envato.d.pr/UROXXf
– https://envato.d.pr/qiP9x4
– https://envato.d.pr/kUK69L
– https://envato.d.pr/dMsnwm

fixed: we had fixed similar things.

54. Styling issue: https://envato.d.pr/aHraE3 2. Inconsistent padding: https://envato.d.pr/cb0Cpm 3. And again, some of the spacing issues from the previous reviews remain. Any screenshots provided are simply examples. There may be more issues that are similar. Ensure you check all files and fix all instances of each issue before resubmitting. Not doing so may delay your final approval.
Fixed: 

 

 

Spacing and padding issue please check image screenshots from issue 46,47,49,50,51.

53. Padding still needs improving in some areas. Example(s): https://envato.d.pr/mg7bU2 and more.
Fixed: 

52. Some areas still feel unfinished. Example(s): https://envato.d.pr/C8VyXF (chaotic style, inconsistent alignment, etc).
Fixed:

We had aligned. And we also have more attention to details. – Better design consistency. – An overall spacing. – Color contrast and schemes.

51. WooCommerce pages look unfinished. Example(s): https://envato.d.pr/vcNfpl and more.
Fixed: 

50. Make sure to fix all console errors: https://envato.d.pr/lYpF9E
fixed: 

49. Once again: Improve visual hierarchy: focus on better defining which areas of this item should demand more attention and creating a logical structure to the design. For more information, please read: http://webdesign.tutsplus.com/articles/an-introduction-to-hierarchy-webdesign-14947 and https://webdesign.tutsplus.com/articles/understanding-typographic-hierarchy–webdesign-11636 Example(s): https://envato.d.pr/T5Z9VY and more.

Fixed: 

48. AGAIN: Filter functionality not working: https://envato.d.pr/zzWYdK
Fixed: Now if you want to use that. Just add content widget for that and enable filter in theme options.

47. AGAIN: There are a few inconsistent spacing/padding as well as alignment issues throughout the design. I’d like you to go over it with a fine toothed comb and weed out these basic design issues. Example(s): – https://envato.d.pr/BgnSYq

46. AGAIN: The typographic hierarchy of this item requires additional work. For more information, please read: http://webdesign.tutsplus.com/articles/understanding-typographic-hierarchy–webdesign-11636 Example(s): – https://envato.d.pr/MBx6ns
fixed:

45. Make sure all the WP default widgets display properly in all widgetized areas. You can check with monster widgets plugin. – https://envato.d.pr/UlDzFjhttps://envato.d.pr/HeeKyE
fixed:

we had tried to add all widget areas to all of widget. And test again for good display.

44. Remove all unrelated Redux dev and non-dev items such as: – https://envato.d.pr/qGPUHU
fixed: All of similar things had fixed.

43. Filter functionality not working: https://envato.d.pr/zzWYdK
Fixed: Now if you want to use that. Just add content widget for that and enable filter in theme options.

42. Blurry images: – https://envato.d.pr/SojBa1 – https://envato.d.pr/GkLq92
Fixed: we had change some images to webfont.

41. There are a few inconsistent spacing/padding as well as alignment issues throughout the design. I’d like you to go over it with a fine toothed comb and weed out these basic design issues. Example(s): – https://envato.d.pr/BgnSYq
Fixed:

40. The typographic hierarchy of this item requires additional work. For more information, please read: http://webdesign.tutsplus.com/articles/understanding-typographic-hierarchy–webdesign-11636 Example(s): – https://envato.d.pr/MBx6ns
Fixed: 

39. Default instal does not look quite your demo: – https://envato.d.pr/FPdGjthttps://envato.d.pr/miBGuX
fixed: we had fixed that.

38. Some of your files contain validation errors that will need to be fixed. Please be sure that all files validate before resubmitting. You can validate HTML at http://validator.w3.org – https://validator.w3.org/nu/?doc=http%3A%2F%2Fwp.jmstheme.com%2Ferado%2F

fixed: we have checked all of page. And they have no more errors without some allowed warnings.

37. Blog area still looks pretty bland, basic and incomplete: – https://envato.d.pr/MJGwdr – https://envato.d.pr/Q6o8IW A significant amount of improvements are needed. – Visual hierarchy. – Typography. – Forms and buttons. – More attention to details. – Better design consistency. – An overall spacing. – Color contrast and schemes. Here are some resources for you: – https://tympanus.net/codrops/2012/04/10/successful-web-design-its-all-about-the-details/ – http://blog.usabilla.com/visual-appeal-web-design/ – https://medium.com/wd-tips-tricks – https://www.impactbnd.com/blog/10-essential-tips-for-improving-your-web-design – http://www.huffingtonpost.com/aj-agrawal/10-ways-to-improve-your-w_b_10904662.html – https://medium.com/product-design-ux-ui/web-design-101-embrace-the-content-or-how-to-design-better-content-rich-websites-31a9665457fc – http://practicaltypography.com – http://spencermortensen.com/articles/typographic-scale/
fixed: We had changed alot of thing for that page. And we also have more attention to details. – Better design consistency. – An overall spacing. – Color contrast and schemes.

36. Improve styling: https://envato.d.pr/iXoyxq

35. Inappropriate page title: https://envato.d.pr/JC7z2b 5. There are a few inconsistent spacing/padding as well as alignment issues throughout the design. I’d like you to go over it with a fine toothed comb and weed out these basic design issues. Example(s): https://envato.d.pr/TtKEyT

34. Styling issues: https://envato.d.pr/9qo9dB 3. WooCommerce inner pages look unfinished: https://envato.d.pr/0moxvY and more.
fixed:

33. Icons still look blurry: https://envato.d.pr/IUP8kD
fixed: we had changed them by webfont.

32. Scripts and styles should not be hardcoded anywhere in your theme or added any other way but with wp_enqueue_* hook and to be added from the functions file. This includes custom JS/CSS. For inline styles use: https://developer.wordpress.org/reference/functions/wp_add_inline_style/ and for scripts https://developer.wordpress.org/reference/functions/wp_add_inline_script/
fixed: All of similar things had fixed.

31. Under no circumstances should you try to trick review tools such as the Theme Check plugin or to try to hide code that is in violation of these requirements. For example: https://envato.d.pr/vCYeoc and more.
fixed: All of similar things had fixed.

30. A unique prefix must be used for all function names, classes, hooks, public/global variables, action/filter hooks, custom image sizes, constants, database entries, theme-specific scripts and theme-specific styles to avoid conflicts with plugins and other themes. Prefixes should consist of either themename_, authorname_ or frameworkname_. While multiple prefixes are allowed (theme-specific, framework and external PHP libraries), they must be consistent, at least three characters, and unique (ie not using a common term such as ‘seo’). Reference: http://themereview.co/prefix-all-the-things/ Third Party Scripts: Third party scripts/ styles must not be prefixed or suffixed to avoid double loading. Reference: https://github.com/grappler/wp-standard-handles WordPress Core Prefixes: The wp_ prefix is reserved for WordPress core functionality and must not be used by a theme. Prefixes must never begin with an underscore or hyphen. Example(s): https://envato.d.pr/nhp4wu
fixed: All of similar things had fixed.

29. Themes must not have any PHP notices, warnings, or errors. It is recommended that development be done with errors enabled and WP_DEBUG set to true. You could alternatively install the Debug Bar plugin: https://wordpress.org/plugins/debug-bar/ Example(s): https://envato.d.pr/8wGKdp
fixed: All of similar things had fixed.

28. Empty areas should not display unless content is set: https://envato.d.pr/aXQaEi
fixed: All of similar things had fixed.

27. Icons look blurry: https://envato.d.pr/IUP8kD I’d recommend to use a webfont or SVGs
fixed: we had changed them by webfont.

26. All JavaScript should be written with “use strict” mode on. For example, you can do this with jQuery as follows: (function($) { “use strict"; // Author code here })(jQuery); https://envato.d.pr/WgdBC4 https://envato.d.pr/rTzwkQ 2. Documentation may be bundled in your download, but it must also be available and accessible online.
fixed: we had used that mode on with all javascript.

25. Use .on() rather than .click(), .bind(), .hover(), .submit() etc… https://envato.d.pr/VGnXQg
fixed: All of similar things had fixed.

24. Use the correct escaping function for the context where it’s rendered. Example(s): – https://envato.d.pr/gThNAk as you’re escaping an attributes esc_attr__ instead.
fixed: All of similar things had fixed.

23. Don’t leave unused code fragments as comments in the code. Please check all your files. Example(s): – https://envato.d.pr/qD2cA1
fixed: All of similar things had fixed.

22. esc_html_e already echoes strings. No need to have it inside echo functions again: https://envato.d.pr/CN03zO
fixed: we had fixed similar things.

21. Low contrast. Please ensure the use of colours doesn’t affect readability and user experience. – https://envato.d.pr/6lkO0T
fixed: All of similar thing had fixed. (photo above)

20. Please ensure that your item looks and functions properly on mobile devices as well. Some examples of issues found while reviewing your theme on mobile devices but there may be more: – https://envato.d.pr/ymK4Lu
fixed:

All of similar things had fixed.

19. There are a few inconsistent spacing/padding as well as alignment issues throughout the design. I’d like you to go over it with a fine toothed comb and weed out these basic design issues. Example(s): – https://envato.d.pr/5psJSO
fixed: There ís a post with big height image in slide so it causes that problem, hidden arrow.

18. Themes execute the presentation and styling of content while plugins handle content creation and functionality. Anything users will lose upon switching themes is classified as plugin territory. Here are some common examples: – Analytics – SEO options – Forms – Non-design related meta boxes – Resource caching – Dashboard widgets – Custom Post Types – Custom Taxonomies – Shortcodes – Social media “like”, “follow” and “share” buttons Anything that falls into plugin territory must be added via a custom plugin. You may use TGM Plugin Activation or equivalent to prompt the user to install the plugin on theme activation, but it cannot be activated without user action. Example(s): – https://envato.d.pr/lmJhqx
fixed: we had moved it to plugins and user can enable or disable them.

17. WooCommerce inner pages need attention: – https://envato.d.pr/SVC3Bj
fixed:

16. Theme does not look quite like your demo on activation: – https://envato.d.pr/IyQBxn https://envato.d.pr/WbRJq8https://envato.d.pr/hp3dH9
fixed: we had fixed that for new installation.

15. You should avoid and not to hardcode custom body_class(). Main reason for this is being able to remove the class when needed i.e. child themes. What you can do – https://gist.github.com/kailoon/d4d22c9204909dff21eb ref: http://themeshaper.com/2014/11/20/mastering-the-post_class-function/ https://codex.wordpress.org/Function_Reference/body_class#Add_Classes_By_Filters
fixed: we had changed that code and similar things.

14. Please ensure your .POT translation file is up to date. Having an outdated .POT file limits the translatable functionality of your theme, which will negatively affect international customers>
fixed: .POT translation file was to be updated.

13. All theme text strings are to be translatable and properly escaped. https://gist.github.com/kailoon/01fa8e95d2e910e666c6 example(s) from your code and there are more: https://envato.d.pr/LTnLWZ
fixed: All theme text strings were to be translatabled and properly escaped.

12. Parts of your theme do not load completely – https://envato.d.pr/uFKfuF
fixed:

11. Please import the Theme Unit Test [http://codex.wordpress.org/Theme_Unit_Test] file and make sure that: – All default content is formatted properly. – Posts display correctly, with no apparent visual problems or errors. – Posts display in correct order. – Page navigation displays and works correctly. – As “sticky posts" are a core feature, the theme should style and display them appropriately. – Lack of body text should not adversely impact the layout. – Theme must incorporate both the “Tag" and the “Category" taxonomies in some manner. – Floats are cleared properly for floated element (thumbnail image) at the end of the post content. Reference link: https://wpthemetestdata.wordpress.com/
fixed: we tested all of page width THeme Unit Test. And they showed the correct results.

10. Please ensure sure all default WordPress widgets display properly in all widgetized areas.
fixed: we had added all widget areas to all of widget. And test again for good display.

9. Menu styling needs attention – https://envato.d.pr/9MKWHv
fixed:

8. Please make sure that your theme doesn’t raise any PHP errors, notices or warnings. Enabling wp_debug can help you with this. https://envato.d.pr/rNcKxI
fixed: we are test all of page and they have no more any php error, notices or warnings width wp_debug.

7. Parts of your demo still appear unfinished/incomplete. example; https://envato.d.pr/VfLKEL
fixed this page and check to fix more other pages.

6. The typographic hierarchy of this item requires additional work.
Fixed: We had more attention to ypographic hierarchy of this item.

5. There are spacing and alignment issues in this item. Please make sure that all elements are aligned properly and spacing is consistent from section to section. Here are some articles with more information regarding negative space and proper spacing
Fixed: We had aligned consistent macro padding and micro padding.

4. It’s recommended that you pair complementary fonts that add to the design aesthetic you’re going for. In general, a design should utilize less than three (ideally two) font variations that each compliment another — not compete for attention https://envato.d.pr/ln6JqU
fixed: Only use 2 font family.

3. Inner pages are bland and feel more like a framework than a fully finished theme http://wp.jmstheme.com/erado/about-us
fixed: we change style of inner page to map with site style.

2. Improve performance https://envato.d.pr/NNqS0d https://envato.d.pr/uQsOrt
fixed (some time speed test has cache, please try to check 2-3 times): 

mobile

desktop

1. Envato Theme Check remove all warning, notice, error, …

fixed: